-
Notifications
You must be signed in to change notification settings - Fork 30.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
doc: minor rewording to the GitHub issue/pr templates
- Templates are now a bit more consistent with phrasing. - Simplified a bit. PR-URL: #7403 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
- Loading branch information
1 parent
c521249
commit ba8dac9
Showing
2 changed files
with
10 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,22 @@ | ||
<!-- | ||
Thank you for your pull request. Please review below requirements. | ||
Bug fixes and new features should include tests and possibly a benchmark. | ||
Bug fixes and new features should include tests and possibly benchmarks. | ||
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md | ||
--> | ||
|
||
##### Checklist | ||
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> | ||
|
||
- [ ] `make -j4 test` (UNIX) or `vcbuild test nosign` (Windows) passes | ||
- [ ] a test and/or benchmark is included | ||
- [ ] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes | ||
- [ ] tests and/or benchmarks are included | ||
- [ ] documentation is changed or added | ||
- [ ] the commit message follows commit guidelines | ||
|
||
- [ ] commit message follows commit guidelines | ||
|
||
##### Affected core subsystem(s) | ||
<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) --> | ||
<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). --> | ||
|
||
|
||
##### Description of change | ||
<!-- provide a description of the change below this comment --> | ||
<!-- Provide a description of the change below this comment. --> |