Skip to content

Commit bc64cf2

Browse files
thefourtheyeMylesBorins
authored andcommittedMay 18, 2017
build: make linter targets silent
The linter targets are printing the commands they execute on screen. This patch reduces the noise by not printing the commands. PR-URL: #12423 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 26fcc7a commit bc64cf2

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed
 

‎Makefile

+4-1
Original file line numberDiff line numberDiff line change
@@ -735,10 +735,12 @@ bench-idle:
735735
$(NODE) benchmark/idle_clients.js &
736736

737737
jslint:
738+
@echo "Running JS linter..."
738739
$(NODE) tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules \
739740
benchmark lib test tools
740741

741742
jslint-ci:
743+
@echo "Running JS linter..."
742744
$(NODE) tools/jslint.js $(PARALLEL_ARGS) -f tap -o test-eslint.tap \
743745
benchmark lib test tools
744746

@@ -761,12 +763,13 @@ CPPLINT_FILES = $(filter-out $(CPPLINT_EXCLUDE), $(wildcard \
761763
))
762764

763765
cpplint:
766+
@echo "Running C++ linter..."
764767
@$(PYTHON) tools/cpplint.py $(CPPLINT_FILES)
765768
@$(PYTHON) tools/check-imports.py
766769

767770
ifneq ("","$(wildcard tools/eslint/lib/eslint.js)")
768771
lint:
769-
EXIT_STATUS=0 ; \
772+
@EXIT_STATUS=0 ; \
770773
$(MAKE) jslint || EXIT_STATUS=$$? ; \
771774
$(MAKE) cpplint || EXIT_STATUS=$$? ; \
772775
exit $$EXIT_STATUS

0 commit comments

Comments
 (0)
Please sign in to comment.