doc: fix order of AtExit callbacks in addons.md

danbev · MylesBorins · commit c0e47e4f220a · 2017-09-19T14:26:58.000-04:00
The sanity_check AtExit callback needs to come last to verify that the other callbacks have been completed. This was not noticed before as this code was not been executed. PR-URL: #14048 Reviewed-By: Michaël Zasso <targos@protonmail.com>
diff --git a/doc/api/addons.md b/doc/api/addons.md
@@ -1090,10 +1090,10 @@ static void sanity_check(void*) {
 }
 
 void init(Local<Object> exports) {
-  AtExit(sanity_check);
   AtExit(at_exit_cb2, cookie);
   AtExit(at_exit_cb2, cookie);
   AtExit(at_exit_cb1, exports->GetIsolate());
+  AtExit(sanity_check);
 }
 
 NODE_MODULE(addon, init)

Original file line number	Diff line number	Diff line change
`@@ -1090,10 +1090,10 @@ static void sanity_check(void*) {`
`1090`	`1090`	`}`
`1091`	`1091`
`1092`	`1092`	`void init(Local<Object> exports) {`
`1093`		`- AtExit(sanity_check);`
`1094`	`1093`	`AtExit(at_exit_cb2, cookie);`
`1095`	`1094`	`AtExit(at_exit_cb2, cookie);`
`1096`	`1095`	`AtExit(at_exit_cb1, exports->GetIsolate());`
	`1096`	`+ AtExit(sanity_check);`
`1097`	`1097`	`}`
`1098`	`1098`
`1099`	`1099`	`NODE_MODULE(addon, init)`