Skip to content

Commit

Permalink
test: unskip v8-updates/test-linux-perf-logger
Browse files Browse the repository at this point in the history
Refs: #51308
Refs: #52821
PR-URL: #52869
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
  • Loading branch information
lukealbao authored and targos committed Jun 1, 2024
1 parent fe007cd commit c1138db
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions test/v8-updates/test-linux-perf-logger.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@
//
// NOTE: This test runs only on linux, as that is the only platform supported by perf, and
// accordingly the only platform where `perf-basic-prof*` v8 flags are available.

//
// MAINTAINERS' NOTE: As of early 2024, the most common failure mode for this test suite
// is for v8 options to change from version to version. If this suite fails, look there first.
// We use options to forcibly require certain test cases to JIT code, and the nodeFlags to do
// so can change.

const common = require('../common');
if (!common.isLinux) {
Expand Down Expand Up @@ -48,7 +52,8 @@ const testCases = [
},
{
title: '--perf-basic-prof compiled',
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan'],
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan',
'--minimum-invocations-before-optimization=0'],
matches: [
'test-regex',
'~functionOne .+/linux-perf-logger.js',
Expand All @@ -66,7 +71,8 @@ const testCases = [
},
{
title: '--perf-basic-prof-only-functions compiled',
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan'],
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan',
'--minimum-invocations-before-optimization=0'],
matches: [
'~functionOne .+/linux-perf-logger.js',
'~functionTwo .+/linux-perf-logger.js',
Expand Down

0 comments on commit c1138db

Please sign in to comment.