Skip to content

Commit c60810a

Browse files
bnoordhuisMylesBorins
authored andcommitted
test: increase slop limit in memory leak test
It transpires that the extra bookkeeping in debug builds sometimes makes the increase in RSS go _just_ over the 5 MB limit, by fewer than 100 kB. Double the limit so we hopefully don't run into it any time again soon. The memory leak it tests for was one where RSS grew by hundreds of megabytes over the lifetime of the test; 5 vs. 10 MB is insignificant. Fixes: #21076 PR-URL: #21080 Refs: #21076 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent fda8654 commit c60810a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/parallel/test-crypto-dh-leak.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ const after = process.memoryUsage().rss;
2323

2424
// RSS should stay the same, ceteris paribus, but allow for
2525
// some slop because V8 mallocs memory during execution.
26-
assert(after - before < 5 << 20, `before=${before} after=${after}`);
26+
assert(after - before < 10 << 20, `before=${before} after=${after}`);

0 commit comments

Comments
 (0)