Skip to content

Commit

Permalink
fs: fix to not return for void function
Browse files Browse the repository at this point in the history
PR-URL: #50769
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
  • Loading branch information
Jungku Lee authored and UlisesGascon committed Dec 19, 2023
1 parent 158db2d commit cada22e
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions lib/fs.js
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ function close(fd, callback = defaultCloseCallback) {
function closeSync(fd) {
fd = getValidatedFd(fd);

return binding.close(fd);
binding.close(fd);
}

/**
Expand Down Expand Up @@ -784,7 +784,7 @@ function readv(fd, buffers, position, callback) {
if (typeof position !== 'number')
position = null;

return binding.readBuffers(fd, buffers, position, req);
binding.readBuffers(fd, buffers, position, req);
}

ObjectDefineProperty(readv, kCustomPromisifyArgsSymbol,
Expand Down Expand Up @@ -860,7 +860,8 @@ function write(fd, buffer, offsetOrOptions, length, position, callback) {

const req = new FSReqCallback();
req.oncomplete = wrapper;
return binding.writeBuffer(fd, buffer, offset, length, position, req);
binding.writeBuffer(fd, buffer, offset, length, position, req);
return;
}

validateStringAfterArrayBufferView(buffer, 'buffer');
Expand All @@ -881,7 +882,7 @@ function write(fd, buffer, offsetOrOptions, length, position, callback) {

const req = new FSReqCallback();
req.oncomplete = wrapper;
return binding.writeString(fd, str, offset, length, req);
binding.writeString(fd, str, offset, length, req);
}

ObjectDefineProperty(write, kCustomPromisifyArgsSymbol,
Expand Down Expand Up @@ -971,7 +972,7 @@ function writev(fd, buffers, position, callback) {
if (typeof position !== 'number')
position = null;

return binding.writeBuffers(fd, buffers, position, req);
binding.writeBuffers(fd, buffers, position, req);
}

ObjectDefineProperty(writev, kCustomPromisifyArgsSymbol, {
Expand Down Expand Up @@ -1177,7 +1178,8 @@ function rmdir(path, options, callback) {
if (err === false) {
const req = new FSReqCallback();
req.oncomplete = callback;
return binding.rmdir(path, req);
binding.rmdir(path, req);
return;
}
if (err) {
return callback(err);
Expand All @@ -1190,7 +1192,7 @@ function rmdir(path, options, callback) {
validateRmdirOptions(options);
const req = new FSReqCallback();
req.oncomplete = callback;
return binding.rmdir(path, req);
binding.rmdir(path, req);
}
}

Expand Down Expand Up @@ -1296,7 +1298,7 @@ function fdatasync(fd, callback) {
*/
function fdatasyncSync(fd) {
fd = getValidatedFd(fd);
return binding.fdatasync(fd);
binding.fdatasync(fd);
}

/**
Expand All @@ -1321,7 +1323,7 @@ function fsync(fd, callback) {
*/
function fsyncSync(fd) {
fd = getValidatedFd(fd);
return binding.fsync(fd);
binding.fsync(fd);
}

/**
Expand Down Expand Up @@ -1888,7 +1890,7 @@ function unlink(path, callback) {
*/
function unlinkSync(path) {
path = pathModule.toNamespacedPath(getValidatedPath(path));
return binding.unlink(path);
binding.unlink(path);
}

/**
Expand Down Expand Up @@ -2929,7 +2931,7 @@ realpath.native = (path, options, callback) => {
path = getValidatedPath(path);
const req = new FSReqCallback();
req.oncomplete = callback;
return binding.realpath(pathModule.toNamespacedPath(path), options.encoding, req);
binding.realpath(pathModule.toNamespacedPath(path), options.encoding, req);
};

/**
Expand Down

0 comments on commit cada22e

Please sign in to comment.