Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build: go faster, drop -fno-omit-frame-pointer
This flag was added back in 2013 to support postmortem debugging on Linux but it has a pretty bad impact on performance (up to 10%) and I don't think it's actually necessary to get meaningful stack traces. Maybe with mdb but gdb and lldb seem to manage just fine. Even if the flag is necessary for postmortem debugging, I don't think it's appropriate to make performance for all users suffer for the benefit of a fringe group. PR-URL: #44452 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
- Loading branch information