Skip to content

Commit

Permalink
test: remove flaky designation for test on AIX
Browse files Browse the repository at this point in the history
#5085 has been completed so
presumably test-fs-watch is not flaky on AIX anymore. Remove flaky
designation from sequential.status.

PR-URL: #12564
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
  • Loading branch information
Trott authored and evanlucas committed May 2, 2017
1 parent cfd9144 commit d10eb83
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
5 changes: 0 additions & 5 deletions test/sequential/sequential.status
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,4 @@ test-benchmark-child-process : PASS,FLAKY

[$system==freebsd]

# fs-watch currently needs special configuration on AIX and we
# want to improve under https://github.com/nodejs/node/issues/5085.
# Tests are disabled so CI can be green and we can spot other
# regressions until this work is complete
[$system==aix]
test-fs-watch : FAIL,PASS
5 changes: 3 additions & 2 deletions test/sequential/test-fs-watch.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ const fs = require('fs');

const expectFilePath = common.isWindows ||
common.isLinux ||
common.isOSX;
common.isOSX ||
common.isAix;

let watchSeenOne = 0;
let watchSeenTwo = 0;
Expand Down Expand Up @@ -80,7 +81,7 @@ const filepathThree = path.join(testsubdir, filenameThree);
assert.doesNotThrow(
function() {
const watcher = fs.watch(testsubdir, function(event, filename) {
const renameEv = common.isSunOS ? 'change' : 'rename';
const renameEv = common.isSunOS || common.isAix ? 'change' : 'rename';
assert.strictEqual(renameEv, event);
if (expectFilePath) {
assert.strictEqual('newfile.txt', filename);
Expand Down

0 comments on commit d10eb83

Please sign in to comment.