Skip to content

Commit

Permalink
test: fix test-benchmark-buffer
Browse files Browse the repository at this point in the history
Using `len=2` in test-benchmark-buffer was resulting in a `RangeError`
in buffer-base64-encode.js. Change to `len=256` which works in all
buffer benchmarks.

PR-URL: #27260
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information
Trott committed Apr 18, 2019
1 parent 3973354 commit d5bb500
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/benchmark/test-benchmark-buffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ runBenchmark('buffers',
'charsPerLine=6',
'encoding=utf8',
'endian=BE',
'len=2',
'len=256',
'linesCount=1',
'method=',
'n=1',
Expand Down

0 comments on commit d5bb500

Please sign in to comment.