Skip to content

Commit

Permalink
lib: remove the comment of base64 validation
Browse files Browse the repository at this point in the history
Since there's a comment about the 'base64' validation needed, and this
will result in a breaking change, so this should be removed.

PR-URL: #29201
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
  • Loading branch information
Maledong authored and antsmartian committed Aug 24, 2019
1 parent d27cc1b commit d5c3837
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions lib/internal/validators.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,6 @@ function validateEncoding(data, encoding) {
throw new ERR_INVALID_ARG_VALUE('encoding', encoding,
`is invalid for data of length ${length}`);
}

// TODO(bnoordhuis) Add BASE64 check?
}

module.exports = {
Expand Down

0 comments on commit d5c3837

Please sign in to comment.