lib: remove top-level getOptionValue() calls in lib/internal/modules

PR-URL: #61769
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>

Author: joyeecheung

lib/internal/modules/esm/formats.js

@@ -9,13 +9,63 @@ const {
   StringPrototypeSlice,
 } = primordials;
 const { getOptionValue } = require('internal/options');
-const {
-  extensionFormatMap,
-  getFormatOfExtensionlessFile,
-  mimeToFormat,
-} = require('internal/modules/esm/formats');
+const { getValidatedPath } = require('internal/fs/utils');
+const fsBindings = internalBinding('fs');
+const { internal: internalConstants } = internalBinding('constants');
+
+const extensionFormatMap = {
+  '__proto__': null,
+  '.cjs': 'commonjs',
+  '.js': 'module',
+  '.json': 'json',
+  '.mjs': 'module',
+  '.wasm': 'wasm',
+};
+
+function initializeExtensionFormatMap() {
+  if (getOptionValue('--experimental-addon-modules')) {
+    extensionFormatMap['.node'] = 'addon';
+  }
+
+  if (getOptionValue('--strip-types')) {
+    extensionFormatMap['.ts'] = 'module-typescript';
+    extensionFormatMap['.mts'] = 'module-typescript';
+    extensionFormatMap['.cts'] = 'commonjs-typescript';
+  }
+}
 
-const detectModule = getOptionValue('--experimental-detect-module');
+/**
+ * @param {string} mime
+ * @returns {string | null}
+ */
+function mimeToFormat(mime) {
+  if (
+    RegExpPrototypeExec(
+      /^\s*(text|application)\/javascript\s*(;\s*charset=utf-?8\s*)?$/i,
+      mime,
+    ) !== null
+  ) { return 'module'; }
+  if (mime === 'application/json') { return 'json'; }
+  if (mime === 'application/wasm') { return 'wasm'; }
+  return null;
+}
+
+/**
+ * For extensionless files in a `module` package scope, we check the file contents to disambiguate between ES module
+ * JavaScript and Wasm.
+ * We do this by taking advantage of the fact that all Wasm files start with the header `0x00 0x61 0x73 0x6d` (`_asm`).
+ * @param {URL} url
+ * @returns {'wasm'|'module'}
+ */
+function getFormatOfExtensionlessFile(url) {
+  const path = getValidatedPath(url);
+  switch (fsBindings.getFormatOfExtensionlessFile(path)) {
+    case internalConstants.EXTENSIONLESS_FORMAT_WASM:
+      return 'wasm';
+    default:
+      return 'module';
+  }
+}
 const { containsModuleSyntax } = internalBinding('contextify');
 const { getPackageScopeConfig, getPackageType } = require('internal/modules/package_json_reader');
 const { fileURLToPath } = require('internal/url');
@@ -35,6 +85,7 @@ const protocolHandlers = {
  * @returns {'module'|'commonjs'}
  */
 function detectModuleFormat(source, url) {
+  const detectModule = getOptionValue('--experimental-detect-module');
   if (!source) { return detectModule ? null : 'commonjs'; }
   if (!detectModule) { return 'commonjs'; }
   return containsModuleSyntax(`${source}`, fileURLToPath(url), url) ? 'module' : 'commonjs';
@@ -216,4 +267,5 @@ module.exports = {
   defaultGetFormatWithoutErrors,
   extensionFormatMap,
   extname,
+  initializeExtensionFormatMap,
 };

lib/internal/modules/esm/get_format.js

@@ -29,9 +29,6 @@ const { realpathSync } = require('fs');
 const { getOptionValue } = require('internal/options');
 // Do not eagerly grab .manifest, it may be in TDZ
 const { sep, posix: { relative: relativePosixPath }, resolve } = require('path');
-const preserveSymlinks = getOptionValue('--preserve-symlinks');
-const preserveSymlinksMain = getOptionValue('--preserve-symlinks-main');
-const inputTypeFlag = getOptionValue('--input-type');
 const { URL, pathToFileURL, fileURLToPath, isURL, URLParse } = require('internal/url');
 const { getCWDURL, setOwnProperty } = require('internal/util');
 const { canParse: URLCanParse } = internalBinding('url');
@@ -982,7 +979,7 @@ function defaultResolve(specifier, context = {}) {
     // input, to avoid user confusion over how expansive the effect of the
     // flag should be (i.e. entry point only, package scope surrounding the
     // entry point, etc.).
-    if (inputTypeFlag) { throw new ERR_INPUT_TYPE_NOT_ALLOWED(); }
+    if (getOptionValue('--input-type')) { throw new ERR_INPUT_TYPE_NOT_ALLOWED(); }
   }
 
   conditions = getConditionsSet(conditions);
@@ -992,7 +989,7 @@ function defaultResolve(specifier, context = {}) {
       specifier,
       parentURL,
       conditions,
-      isMain ? preserveSymlinksMain : preserveSymlinks,
+      isMain ? getOptionValue('--preserve-symlinks-main') : getOptionValue('--preserve-symlinks'),
     );
   } catch (error) {
     // Try to give the user a hint of what would have been the

lib/internal/modules/esm/resolve.js

@@ -161,6 +161,9 @@ function prepareExecution(options) {
     assert(!initializeModules);
   }
 
+  const { initializeExtensionFormatMap } = require('internal/modules/esm/get_format');
+  initializeExtensionFormatMap();
+
   setupVmModules();
   if (initializeModules) {
     initializeModuleLoaders({ shouldSpawnLoaderHookWorker, shouldPreloadModules });

lib/internal/process/pre_execution.js

@@ -48,7 +48,7 @@ const CJSModule = require('internal/modules/cjs/loader').Module;
 
 const {
   extensionFormatMap,
-} = require('internal/modules/esm/formats');
+} = require('internal/modules/esm/get_format');
 
 const path = require('path');
 const fs = require('fs');

lib/internal/repl/completion.js

@@ -118,6 +118,7 @@ expected.beforePreExec = new Set([
 ]);
 
 expected.atRunTime = new Set([
+  'NativeModule internal/modules/esm/get_format',
   'NativeModule internal/process/pre_execution',
 ]);