-
Notifications
You must be signed in to change notification settings - Fork 30k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
http2: do not register unnecessary listeners
PR-URL: #27987 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
Showing
2 changed files
with
52 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
test/parallel/test-http2-client-request-listeners-warning.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
if (!common.hasCrypto) | ||
common.skip('missing crypto'); | ||
const http2 = require('http2'); | ||
const EventEmitter = require('events'); | ||
|
||
// This test ensures that a MaxListenersExceededWarning isn't emitted if | ||
// more than EventEmitter.defaultMaxListeners requests are started on a | ||
// ClientHttp2Session before it has finished connecting. | ||
|
||
process.on('warning', common.mustNotCall('A warning was emitted')); | ||
|
||
const server = http2.createServer(); | ||
server.on('stream', (stream) => { | ||
stream.respond(); | ||
stream.end(); | ||
}); | ||
|
||
server.listen(common.mustCall(() => { | ||
const client = http2.connect(`http://localhost:${server.address().port}`); | ||
|
||
function request() { | ||
return new Promise((resolve, reject) => { | ||
const stream = client.request(); | ||
stream.on('error', reject); | ||
stream.on('response', resolve); | ||
stream.end(); | ||
}); | ||
} | ||
|
||
const requests = []; | ||
for (let i = 0; i < EventEmitter.defaultMaxListeners + 1; i++) { | ||
requests.push(request()); | ||
} | ||
|
||
Promise.all(requests).then(common.mustCall()).finally(common.mustCall(() => { | ||
server.close(); | ||
client.close(); | ||
})); | ||
})); |