Skip to content

Commit

Permalink
timers: remove flaky setInterval test
Browse files Browse the repository at this point in the history
PR-URL: #37227
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
Nitzan Uziely authored and danielleadams committed Feb 16, 2021
1 parent eb08afd commit eb7ec1b
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions test/parallel/test-timers-promisified.js
Original file line number Diff line number Diff line change
Expand Up @@ -348,28 +348,6 @@ process.on('multipleResolves', common.mustNotCall());
assert.strictEqual(loopCount, 5);
}));
}

{
// Check that if we abort when we have some callbacks left,
// we actually call them.
const controller = new AbortController();
const { signal } = controller;
const delay = 10;
let totalIterations = 0;
const timeoutLoop = runInterval(async (iterationNumber) => {
if (iterationNumber === 2) {
await setTimeout(delay * 2);
controller.abort();
}
if (iterationNumber > totalIterations) {
totalIterations = iterationNumber;
}
}, delay, signal);

timeoutLoop.catch(common.mustCall(() => {
assert.ok(totalIterations >= 3, `iterations was ${totalIterations} < 3`);
}));
}
}

{
Expand Down

0 comments on commit eb7ec1b

Please sign in to comment.