Skip to content

Commit

Permalink
test: fix test for inherited properties on vm
Browse files Browse the repository at this point in the history
The known issue is fixed with
#16293.

The text needs to call `Object.hasOwnProperty(this)`
instead of `this.hasOwnProperty()`, otherwise `this` is
from the wrong context is used.

Add a second test case taken verbatim from issue
#5350

PR-URL: #16411
Fixes: #5350
Ref: #16293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
fhinkel committed Oct 25, 2017
1 parent 9c6f6b0 commit ed116dc
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 20 deletions.
20 changes: 0 additions & 20 deletions test/known_issues/test-vm-inherited_properties.js

This file was deleted.

38 changes: 38 additions & 0 deletions test/parallel/test-vm-inherited_properties.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
'use strict';

require('../common');

const vm = require('vm');
const assert = require('assert');

let base = {
propBase: 1
};

let sandbox = Object.create(base, {
propSandbox: { value: 3 }
});

const context = vm.createContext(sandbox);

let result = vm.runInContext('Object.hasOwnProperty(this, "propBase");',
context);

assert.strictEqual(result, false);

// Ref: https://github.com/nodejs/node/issues/5350
base = Object.create(null);
base.x = 1;
base.y = 2;

sandbox = Object.create(base);
sandbox.z = 3;

assert.deepStrictEqual(Object.keys(sandbox), ['z']);

const code = 'x = 0; z = 4;';
result = vm.runInNewContext(code, sandbox);
assert.strictEqual(result, 4);

// Check that y is not an own property.
assert.deepStrictEqual(Object.keys(sandbox), ['z', 'x']);

0 comments on commit ed116dc

Please sign in to comment.