Skip to content

Commit eeda0e5

Browse files
committed
[test balloon]
1 parent 5b77d94 commit eeda0e5

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

common.gypi

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,7 @@
205205
# Disable "warning C4267: conversion from 'size_t' to 'int',
206206
# possible loss of data". Many originate from our dependencies
207207
# and their sheer number drowns out other, more legitimate warnings.
208-
#
209-
# Disable "warning C4251: 'identifier' : class 'type' needs to have dll-interface to be used by clients of class 'type2'"
210-
# Disable "warning C4275: non - DLL-interface classkey 'identifier' used as base for DLL-interface classkey 'identifier'"
211-
# Many V8 method do not comply with the requirements to be dll exported,
212-
# which result in these warnings reported several 1000s times.
213-
# https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4251
214-
# https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-2-c4275
215-
'DisableSpecificWarnings': ['4267', '4251', '4275'],
208+
'DisableSpecificWarnings': ['4267'],
216209
'WarnAsError': 'false',
217210
},
218211
'VCLibrarianTool': {
@@ -286,7 +279,6 @@
286279
'_CRT_NONSTDC_NO_DEPRECATE',
287280
# Make sure the STL doesn't try to use exceptions
288281
'_HAS_EXCEPTIONS=0',
289-
'BUILDING_V8_SHARED=1',
290282
'BUILDING_UV_SHARED=1',
291283
],
292284
}],

0 commit comments

Comments
 (0)