Skip to content

Commit

Permalink
repl: remove deprecated repl.turnOffEditorMode() function
Browse files Browse the repository at this point in the history
This function is deprecated for multiple years and provides very
little benefit to users. Thus, it's removed to improve the
maintainability of the REPL module.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #33286
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
BridgeAR committed May 23, 2020
1 parent a1bcad8 commit f217b2d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 20 deletions.
5 changes: 4 additions & 1 deletion doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -1628,12 +1628,15 @@ supported API.
### DEP0078: `REPLServer.turnOffEditorMode()`
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/33286
description: End-of-Life.
- version: v9.0.0
pr-url: https://github.com/nodejs/node/pull/15136
description: Runtime deprecation.
-->
Type: Runtime
Type: End-of-Life
`REPLServer.turnOffEditorMode()` was removed from userland visibility.
Expand Down
5 changes: 0 additions & 5 deletions lib/repl.js
Original file line number Diff line number Diff line change
Expand Up @@ -1034,11 +1034,6 @@ REPLServer.prototype.setPrompt = function setPrompt(prompt) {
Interface.prototype.setPrompt.call(this, prompt);
};

REPLServer.prototype.turnOffEditorMode = deprecate(
function() { _turnOffEditorMode(this); },
'REPLServer.turnOffEditorMode() is deprecated',
'DEP0078');

const requireRE = /\brequire\s*\(\s*['"`](([\w@./-]+\/)?(?:[\w@./-]*))(?![^'"`])$/;
const fsAutoCompleteRE = /fs(?:\.promises)?\.\s*[a-z][a-zA-Z]+\(\s*["'](.*)/;
const simpleExpressionRE =
Expand Down
14 changes: 0 additions & 14 deletions test/parallel/test-repl-turn-off-editor-mode.js

This file was deleted.

0 comments on commit f217b2d

Please sign in to comment.