Skip to content

Commit

Permalink
test: remove Windows skipping of http keepalive request GC test
Browse files Browse the repository at this point in the history
Remove code to skip Windows in test-http-server-keepalive-req-gc. The
test now works reliably on Windows (I think).

PR-URL: #29354
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
  • Loading branch information
Trott authored and BridgeAR committed Sep 3, 2019
1 parent 7a4ae1a commit f6b005d
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions test/parallel/test-http-server-keepalive-req-gc.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ const onGC = require('../common/ongc');
const { createServer } = require('http');
const { connect } = require('net');

if (common.isWindows) {
// TODO(addaleax): Investigate why and remove the skip.
common.skip('This test is flaky on Windows.');
}

// Make sure that for HTTP keepalive requests, the req object can be
// garbage collected once the request is finished.
// Refs: https://github.com/nodejs/node/issues/9668
Expand Down

0 comments on commit f6b005d

Please sign in to comment.