Skip to content

Commit f9c6fd0

Browse files
committed
src: use unqualified names in node_contextify.cc
This commit removes the usage of qualified names for consistency. PR-URL: #20669 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 6de0f55 commit f9c6fd0

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/node_contextify.cc

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ using v8::Uint8Array;
6464
using v8::UnboundScript;
6565
using v8::Value;
6666
using v8::WeakCallbackInfo;
67+
using v8::WeakCallbackType;
6768

6869
// The vm module executes code in a sandboxed environment with a different
6970
// global object than the rest of the code. This is achieved by applying
@@ -104,7 +105,7 @@ ContextifyContext::ContextifyContext(
104105
// Allocation failure or maximum call stack size reached
105106
if (context_.IsEmpty())
106107
return;
107-
context_.SetWeak(this, WeakCallback, v8::WeakCallbackType::kParameter);
108+
context_.SetWeak(this, WeakCallback, WeakCallbackType::kParameter);
108109
}
109110

110111

@@ -421,7 +422,7 @@ void ContextifyContext::PropertyDefinerCallback(
421422
return;
422423

423424
Local<Context> context = ctx->context();
424-
v8::Isolate* isolate = context->GetIsolate();
425+
Isolate* isolate = context->GetIsolate();
425426

426427
auto attributes = PropertyAttribute::None;
427428
bool is_declared =
@@ -454,13 +455,13 @@ void ContextifyContext::PropertyDefinerCallback(
454455

455456
if (desc.has_get() || desc.has_set()) {
456457
PropertyDescriptor desc_for_sandbox(
457-
desc.has_get() ? desc.get() : v8::Undefined(isolate).As<Value>(),
458-
desc.has_set() ? desc.set() : v8::Undefined(isolate).As<Value>());
458+
desc.has_get() ? desc.get() : Undefined(isolate).As<Value>(),
459+
desc.has_set() ? desc.set() : Undefined(isolate).As<Value>());
459460

460461
define_prop_on_sandbox(&desc_for_sandbox);
461462
} else {
462463
Local<Value> value =
463-
desc.has_value() ? desc.value() : v8::Undefined(isolate).As<Value>();
464+
desc.has_value() ? desc.value() : Undefined(isolate).As<Value>();
464465

465466
if (desc.has_writable()) {
466467
PropertyDescriptor desc_for_sandbox(value, desc.writable());

0 commit comments

Comments
 (0)