Skip to content

Commit

Permalink
buffer: remove unnecessary TODO comments
Browse files Browse the repository at this point in the history
Refs: #4642
PR-URL: #4719
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
pgeiss authored and Myles Borins committed Feb 15, 2016
1 parent 91066b5 commit fb615bd
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions lib/buffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -513,9 +513,6 @@ Buffer.prototype.set = internalUtil.deprecate(function set(offset, v) {
return this[offset] = v;
}, 'Buffer.set is deprecated. Use array indexes instead.');


// TODO(trevnorris): fix these checks to follow new standard
// write(string, offset = 0, length = buffer.length, encoding = 'utf8')
var writeWarned = false;
const writeMsg = 'Buffer.write(string, encoding, offset, length) is ' +
'deprecated. Use write(string[, offset[, length]]' +
Expand Down Expand Up @@ -608,8 +605,6 @@ Buffer.prototype.toJSON = function() {
};


// TODO(trevnorris): currently works like Array.prototype.slice(), which
// doesn't follow the new standard for throwing on out of range indexes.
Buffer.prototype.slice = function slice(start, end) {
const buffer = this.subarray(start, end);
Object.setPrototypeOf(buffer, Buffer.prototype);
Expand Down

0 comments on commit fb615bd

Please sign in to comment.