Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nonstandard WHATWG URL url.toString(true) #10750

Closed
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@domenic
Copy link
Contributor

domenic commented Jan 12, 2017

As with originFor and friends, it should ideally move to a separate export on the url module, instead of extending the standard object with unspecified behavior.

@mscdex mscdex added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 12, 2017
@jasnell
Copy link
Member

jasnell commented Jan 12, 2017

definitely agree that this is not ideal. I would like to have a way of getting back the unicode/idna encoding of the URL without punycode tho so moving something into the url module makes sense.... although it is a bit annoying

@joyeecheung
Copy link
Member

joyeecheung commented Jan 22, 2017

Just noticed #10857 is gonna fix this (although TupleOrigin .toString() still has an unspecified argument).

@TimothyGu
Copy link
Member

Fixed in c5e9654...0d9ea4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment