-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object.defineProperty called inside the vm context fails to copy data properties onto the sandbox #10977
Comments
I think it is a good idea to add the test to the known_issues. |
Agree. A PR would be wonderful :-) |
On a side note, if you want to test different node versions, you probably want nvm. |
#10920 fixes this. |
No need for a PR then, am I right? |
I think it's good to have the test. Either as known issue or as a regression test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Data properties defined with the Object.defineProperty call inside the vm context are not copied onto the sandbox in the current master.
Test:
In v6.2.0 (homebrew installation):
Debugging the core shows failure in GlobalPropertySetterCallback.
does not set 'foo' on the sandbox (property and value are as expected). 'foo' is present on the global object, but also not returned by
in CopyProperties.
The text was updated successfully, but these errors were encountered: