Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: track WHATWG URL issue #216: Host parser UTF-8 failure #11000

Closed
jasnell opened this issue Jan 25, 2017 · 2 comments
Closed

url: track WHATWG URL issue #216: Host parser UTF-8 failure #11000

jasnell opened this issue Jan 25, 2017 · 2 comments
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@jasnell
Copy link
Member

jasnell commented Jan 25, 2017

See: whatwg/url#216

In certain cases, parsing a host containing invalid UTF-8 should fail. New tests are being added to the spec.
@jasnell jasnell added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 25, 2017
@targos
Copy link
Member

targos commented Jan 29, 2017 •
edited
Loading

We are relying on ICU's toASCII function for this and it doesn't fail on input like '\ufffd'.

@TimothyGu
Copy link
Member

This should no longer be an issue after #11549.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasnell @TimothyGu @targos