-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https: certificate validation fails when using servername option #1106
Labels
Comments
I provide a PR incl. test for |
/cc @indutny - seems like an unambiguous bug to me.. |
mscdex
added
confirmed-bug
Issues with confirmed bugs.
https
Issues or PRs related to the https subsystem.
labels
Mar 9, 2015
Surely a bug, @skenqbx please go ahead ;) Please submit a test first, though. Just to make sure that we are on the same page. |
This was referenced Mar 9, 2015
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Agent#createSocket()
overwritesoptions.servername
leading to atls.checkServerIdentity()
against hostname instead of servername.I usually disabled connection pooling in that case, but that is not possible anymore as
ClientRequest#constructor
always sets an agent.Not sure if this is intentional; Did I overlook something in the changelog?
The text was updated successfully, but these errors were encountered: