Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,vm: warn more prominently against executing untrusted code #11550

Closed
bnoordhuis opened this issue Feb 25, 2017 · 3 comments
Closed

doc,vm: warn more prominently against executing untrusted code #11550

bnoordhuis opened this issue Feb 25, 2017 · 3 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. vm Issues and PRs related to the vm subsystem.

Comments

@bnoordhuis
Copy link
Member

The vm module is not a security mechanism. There used to be a prominent warning against executing untrusted code but it seems to have been removed in recent years.

I think it would be good to bring it back because the language around sandboxing can mislead users into thinking the vm module is something it's not.

@bnoordhuis bnoordhuis added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. vm Issues and PRs related to the vm subsystem. labels Feb 25, 2017
@krydos
Copy link
Contributor

krydos commented Feb 25, 2017

Sound good as first contribution. Can I try to do it please?

Will it be ok to put this as Note: ... somewhere at the end of the first section?

@bnoordhuis
Copy link
Member Author

@krydos Yes, that's a good place for it.

@bnoordhuis
Copy link
Member Author

Fixed by 2e74b0d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

No branches or pull requests

2 participants