Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document tls.Server#listen(path, callback) and possible other signatures #11915

Closed
silverwind opened this issue Mar 18, 2017 · 5 comments
Closed

Document tls.Server#listen(path, callback) and possible other signatures #11915

silverwind opened this issue Mar 18, 2017 · 5 comments
Labels
doc Issues and PRs related to the documentations. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. tls Issues and PRs related to the tls subsystem.

Comments

@silverwind
Copy link
Contributor

We currently support unix sockets on https.Server and net.Server, but for some reason not on tls.Server. Seems like an oversight to me, would anyone agree?
@silverwind silverwind added the tls Issues and PRs related to the tls subsystem. label Mar 18, 2017
@joyeecheung joyeecheung added the feature request Issues that request new features to be added to Node.js. label Mar 20, 2017
@sam-github
Copy link
Contributor

I agree, I would have expected it to work.

@silverwind
Copy link
Contributor Author

Looks like it actually already works. I'm able to connect to a TLS unix socket using OpenSSL 1.1.1.

Flagging this as documentation issue. We're likely missing a few .listen signatures in TLS.

@silverwind silverwind added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. and removed feature request Issues that request new features to be added to Node.js. labels Mar 20, 2017
@silverwind silverwind changed the title tls.Server#listen(path, callback) Document tls.Server#listen(path, callback) and possible other signatures Mar 20, 2017
@GeneralMeow
Copy link

Hey there,
Would y'all mind if I took on this issue? It's my first contribution to an OSS project and would love to do it if it's still available.

@silverwind
Copy link
Contributor Author

Sure, go ahead. What needs to be tested is if these method signatures from net#Server are also available on a tls#Server:

https://nodejs.org/api/net.html#net_server_listen_handle_backlog_callback
https://nodejs.org/api/net.html#net_server_listen_options_callback
https://nodejs.org/api/net.html#net_server_listen_path_backlog_callback

I guess it's best to link to the net counterparts instead of duplicating information.

@Trott Trott added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. and removed good first issue Issues that are suitable for first-time contributors. labels Aug 6, 2017
@mgjm mgjm mentioned this issue Oct 6, 2017
Closed
4 tasks
@apapirovski
Copy link
Member

This has been addressed by #16020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fix inconsistent documentation of server.listen() mgjm-fork/node
6 participants
@sam-github @apapirovski @silverwind @Trott @joyeecheung @GeneralMeow