Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the eslint update process #12611

Closed
gibfahn opened this issue Apr 23, 2017 · 2 comments
Closed

Document the eslint update process #12611

gibfahn opened this issue Apr 23, 2017 · 2 comments
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.

Comments

@gibfahn
Copy link
Member

gibfahn commented Apr 23, 2017

See #12563 (comment)

As is, I'm OK with putting eslint-plugin-markdown into tools/eslint/node_modules as long as things break in an understandable way when the plugin is missing after an upgrade. For that matter, the upgrade process probably needs to be documented somewhere and that would be a good place to include the instructions to include the plugin. I might try to do that if I get some time today, but as always, I'd be thrilled if someone beats me to it. (I always forget a step in the upgrade anyway involving a symlink or something to .bin/eslint.js I think?

The symlink step was done in #10771 and #9299

See also #9299 (comment)

@Trott I'm not sure either. How did you create the eslint you committed? What was your sequence? We could probably figure out one that works and document in a README somewhere. Or in the next commit message. You put some effort into your commit to say what you did, but just at a high level.

cc/ @Trott @vsemozhetbyt @sam-github

@gibfahn gibfahn added the doc Issues and PRs related to the documentations. label Apr 23, 2017
@vsemozhetbyt vsemozhetbyt added the tools Issues and PRs related to the tools directory. label Apr 23, 2017
@silverwind
Copy link
Contributor

What not add a make update-js-deps or similar?

@Trott
Copy link
Member

Trott commented Aug 2, 2017

There's now tools/update-eslint.sh. Even if you are on an OS that can't run it, it should still be useful as a step-by-step guide for updating.

@Trott Trott closed this as completed Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

No branches or pull requests

4 participants