Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: bootstrap should fail if ICU is misconfigured #13043

Closed
refack opened this issue May 15, 2017 · 2 comments
Closed

bootstrap: bootstrap should fail if ICU is misconfigured #13043

refack opened this issue May 15, 2017 · 2 comments
Labels
i18n-api Issues and PRs related to the i18n implementation. lib / src Issues and PRs related to general changes in the lib or src directory. url Issues and PRs related to the legacy built-in url module.

Comments

@refack
Copy link
Contributor

refack commented May 15, 2017

  • Version: *
  • Platform: *
  • Subsystem: url,intl

Currently weird things happen if ICU is mis-configured

d:\code\node-cur$ set NODE_ICU_DATA=/

d:\code\node-cur$ node
> var url = require('url')
undefined
> url.parse('http://google.com')
Error: Cannot convert name to ASCII
    at Url.parse (url.js:317:23)
    at Object.urlParse [as parse] (url.js:75:5)
    at repl:1:5
    at ContextifyScript.Script.runInThisContext (vm.js:23:33)
    at REPLServer.defaultEval (repl.js:339:29)
    at bound (domain.js:280:14)
    at REPLServer.runBound [as eval] (domain.js:293:12)
    at REPLServer.onLine (repl.js:536:10)
    at emitOne (events.js:101:20)
    at REPLServer.emit (events.js:191:7)
>

Ref: nodejs/node-gyp#1199

@refack refack added i18n-api Issues and PRs related to the i18n implementation. lib / src Issues and PRs related to general changes in the lib or src directory. url Issues and PRs related to the legacy built-in url module. labels May 15, 2017
@gibfahn
Copy link
Member

gibfahn commented May 16, 2017

cc/ @srl295

@bnoordhuis
Copy link
Member

#13053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation. lib / src Issues and PRs related to general changes in the lib or src directory. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Development

No branches or pull requests

3 participants