Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: allow opt-out of console.* hijacking #13106

Closed
mscdex opened this issue May 18, 2017 · 4 comments
Closed

inspector: allow opt-out of console.* hijacking #13106

mscdex opened this issue May 18, 2017 · 4 comments
Labels
feature request Issues that request new features to be added to Node.js. inspector Issues and PRs related to the V8 inspector protocol

Comments

@mscdex
Copy link
Contributor

mscdex commented May 18, 2017

  • Version: all
  • Platform: n/a
  • Subsystem: inspector

It would be nice to be able to opt out of console.* "hijacking" by the inspector integration for situations where stdout (and/or stderr) is redirected to a file and the process produces a lot of output. Not only is the output duplicated (once in the file and again in the browser), but it can eat up extra memory if you don't need/care to see the console output in the browser.

@mscdex mscdex added feature request Issues that request new features to be added to Node.js. inspector Issues and PRs related to the V8 inspector protocol labels May 18, 2017
@eugeneo
Copy link
Contributor

eugeneo commented May 18, 2017

It is up to debugger front-end to enable/disable Console agent...

Now that we almost have inspector module in Node (#12263) we can start expanding the API. E.g. we can introduce "disableConsoleWatcher", "clearConsoleHistory". Any other suggestions?

@mscdex
Copy link
Contributor Author

mscdex commented May 18, 2017

For my request, I was thinking the opt-out option would just avoid calling installInspectorConsole() in lib/internal/bootstrap_node.js. This would probably be a command-line flag or similar, but I guess it could technically be toggleable during runtime as well by uninstalling/reinstalling the inspector hook?

@Trott
Copy link
Member

Trott commented Aug 13, 2017

Should this remain open? (Seems like it, but maybe something happened in the last three months or maybe it's not a desirable feature for a reason that needs to be documented here or...)

@refack
Copy link
Contributor

refack commented Nov 11, 2018

@refack refack closed this as completed Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

No branches or pull requests

4 participants