Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop support for building addons with VS 2013 in v9 #13372

Closed
bnoordhuis opened this issue Jun 1, 2017 · 4 comments
Closed

build: drop support for building addons with VS 2013 in v9 #13372

bnoordhuis opened this issue Jun 1, 2017 · 4 comments
Labels
build Issues and PRs related to build files or the CI. lts Issues and PRs related to Long Term Support releases. windows Issues and PRs related to the Windows platform.

Comments

@bnoordhuis
Copy link
Member

Continuation of #7989 in a way. See #13263, it turns out that upgrades to V8 requires floating patches to keep addons building with VS 2013.

That is not a good position to be in and not tenable long-term, that's why I propose to raise the baseline to VS 2015 in node 9.

@bnoordhuis bnoordhuis mentioned this issue Jun 1, 2017
2 tasks
@gibfahn
Copy link
Member

gibfahn commented Jun 1, 2017

SGTM, that means we support VS2013 up till 2020 (when Node 8 goes out of support) which seems long enough to me.

cc/ @nodejs/platform-windows

@refack
Copy link
Contributor

refack commented Jun 1, 2017

Just to be clear we're talking about native addons support?
SGTM since MS is giving both VS2017 and VS2017 buildtools for free, and they are able to "cross compile" for older Windows versions.
Sounds relevant also to my CTRL-SHIFT-TAB tab nodejs/node-gyp#1212 a.k.a node-gyp@4

@refack refack added build Issues and PRs related to build files or the CI. lts Issues and PRs related to Long Term Support releases. windows Issues and PRs related to the Windows platform. labels Jun 1, 2017
@tniessen
Copy link
Member

tniessen commented Jun 1, 2017

SGTM. I am not even sure whether Microsoft still offers support for VS2013, their support policy is a little obscured thanks to the number of service packs.

@richardlau
Copy link
Member

This was done by 2062a69 (#14764).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. lts Issues and PRs related to Long Term Support releases. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

5 participants