Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http - ClientRequest abort vs aborted #15283

Closed
ronag opened this issue Sep 8, 2017 · 1 comment
Closed

http - ClientRequest abort vs aborted #15283

ronag opened this issue Sep 8, 2017 · 1 comment
Labels
http Issues or PRs related to the http subsystem.

Comments

@ronag
Copy link
Member

ronag commented Sep 8, 2017

This is a bit confusing.

abort is emitted when abort() is called and aborted SHOULD be called when server unexpectedly closes the socket. However, aborted property is set and corresponds with the abort event not aborted.
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Sep 8, 2017
@odeke-em odeke-em mentioned this issue Sep 11, 2017
Closed
@lpinca
Copy link
Member

lpinca commented Sep 29, 2017

I think this can be closed as there is no 'aborted' event on http.ClientRequest. The documentation bug (#15259) has been fixed.

@ronag ronag closed this as completed Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @lpinca @ronag