Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test,flaky: test-cli-node-options #15284

Closed
refack opened this issue Sep 8, 2017 · 4 comments
Closed

test,flaky: test-cli-node-options #15284

refack opened this issue Sep 8, 2017 · 4 comments
Labels
cli Issues and PRs related to the Node.js command line interface. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@refack
Copy link
Contributor

refack commented Sep 8, 2017

  • Version: 5f22375
  • Platform: Windows
  • Subsystem: test,cli

Consequent of #14195, for some reason

node.exe -e console.log("B")

fails sometimes
any ideas why would be appreciated.

not ok 54 parallel/test-cli-node-options
  ---
  duration_ms: 2.386
  severity: fail
  stack: |-
    assert.js:665
    assert.ifError = function ifError(err) { if (err) throw err; };
                                                      ^
    
    Error: Command failed: c:\workspace\node-test-binary-windows\RUN_SUBSET\1\VS_VERSION\vs2017\label\win2016\Release\node.exe -e console.log("B")
    
        at ChildProcess.exithandler (child_process.js:268:12)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at maybeClose (internal/child_process.js:944:16)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:221:5)
  ...

https://ci.nodejs.org/job/node-test-binary-windows/10993/RUN_SUBSET=1,VS_VERSION=vs2017,label=win2016/console

@refack refack added flaky-test Issues and PRs related to the tests with unstable failures on the CI. cli Issues and PRs related to the Node.js command line interface. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. labels Sep 8, 2017
@BridgeAR
Copy link
Member

BridgeAR commented Jan 17, 2018

Here is a new stack trace:

not ok 59 parallel/test-cli-node-options
  ---
  duration_ms: 2.752
  severity: fail
  stack: |-
    assert.js:447
    assert.ifError = function ifError(err) { if (err) throw err; };
                                                      ^
    
    Error: Command failed: c:\workspace\node-test-binary-windows\Release\node.exe -e console.log("B")
    
    
    #
    # Fatal error in log.cc, line 253
    # Check failed: (perf_output_handle_) != nullptr.
    #
    
        at ChildProcess.exithandler (child_process.js:276:12)
        at ChildProcess.emit (events.js:131:13)
        at maybeClose (internal/child_process.js:943:16)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:220:5)

@richardlau
Copy link
Member

@BridgeAR I think that one was from a CI run for #17600.

@BridgeAR
Copy link
Member

@richardlau thanks, you are right. I did not check that after again after it came up as being flaky.

@Trott
Copy link
Member

Trott commented Oct 18, 2018

It seems like perhaps this should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.

@Trott Trott closed this as completed Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues and PRs related to the Node.js command line interface. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

4 participants