Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabatize errors lint rule does not appear to work #15305

Closed
MylesBorins opened this issue Sep 10, 2017 · 1 comment
Closed

Alphabatize errors lint rule does not appear to work #15305

MylesBorins opened this issue Sep 10, 2017 · 1 comment
Labels
tools Issues and PRs related to the tools directory.

Comments

@MylesBorins
Copy link
Contributor

When testing out the lint rule during an 8.x backport it came to my attention that the lint rule does not appear to work.

I attempted to manually de-alphabatize and then run the linter... it did not flag on anything

Refs: https://github.com/nodejs/node/blob/master/tools/eslint-rules/alphabetize-errors.js

/cc @Trott @maclover7

@maclover7
Copy link
Contributor

After some testing, it seems like the /* eslint-enable alphabetize-errors */ comment isn't working properly.

If you manually specify the alphabetize-errors rule like so...

./node tools/eslint/bin/eslint.js --rule 'alphabetize-errors: error' --rulesdir=tools/eslint-rules lib/internal/errors.js 

... then everything works fine.

If you attempt a normal run via...

./node tools/eslint/bin/eslint.js --rulesdir=tools/eslint-rules lib/internal/errors.js 

... then things break.

Will play around with this a little more.

@mscdex mscdex added the tools Issues and PRs related to the tools directory. label Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

No branches or pull requests

3 participants