Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: improve new error handling further #15589

Closed
BridgeAR opened this issue Sep 24, 2017 · 3 comments
Closed

errors: improve new error handling further #15589

BridgeAR opened this issue Sep 24, 2017 · 3 comments
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. meta Issues and PRs related to the general management of the project.

Comments

@BridgeAR
Copy link
Member

This is a meta issue to track further improvements to the new error handling as soon as we have all errors converted to the internal/errors.
Please leave comments and suggestions if you know of any further inconveniences.

The following is on my mind

  1. We should go through all new error types and check if it makes sense to consolidate some of those. There are very likely redundancies and having very specific error types is often not that helpful.
  2. It is probably a good idea to check if all new errors reflect the situation properly or if it makes sense to improve the error further by rewording it or by adding e.g. the passed in value (I think this sounds like more work than it actually is).
  3. We might also need new error codes for errors that we ported where we used a not perfectly fitting error code or rewrite some parts so it reflects the error type properly again.
  4. ... more suggestions to come ...

Some issues are e.g.

@BridgeAR BridgeAR added errors Issues and PRs related to JavaScript errors originated in Node.js core. meta Issues and PRs related to the general management of the project. labels Sep 24, 2017
@aastikta28
Copy link

Hi @BridgeAR ,

I would like to understand a bit more on the first requirement. And, can I take the first requirement as part of this?

@apapirovski
Copy link
Contributor

@BridgeAR this has become a bit stale. Do you want to perhaps update it to be a bit more current or should we close?

@BridgeAR
Copy link
Member Author

The errors are still a lot of work but we are getting in a better state. Since this never caught a lot of attention, I guess it best to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

3 participants