-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: handling errors while submitting settings #16083
Comments
@trivikr In the JS codebase usually the Line 392 in e012229
|
I will close this since this is not a bug, but feel free to discuss or ask questions in this thread. |
Thanks @joyeecheung |
@trivikr Sorry, I am not sure if I am following what "how C++ methods are mocked" means. If you want to know how the C++ glue code works, taking a look at the v8 Embedder's Guide would help |
Hi @joyeecheung, while writing unit tests in Javascript we sometimes mock functions as we've to test particular file and not it's dependencies. I came across a code which mocks C++ methods in Javascript at node/test/parallel/test-http2-priority-errors.js Lines 52 to 53 in b3a8bf3
|
@trivikr I don't work with HTTP2 tests but I think you can just do something like what the code that you have posted does, and mock |
Yes, I'm using the following line for mocking submitSettings |
As part of improving http2 test coverage in #14985, I was trying to unit test the following code in submitSettings()
node/lib/internal/http2/core.js
Lines 563 to 574 in e012229
While debugging, I'm not able to step into
handle.submitSettings()
to check how the value ofret
is computedI don't see method
submitSettings
forhandle
in the call stack.This appears to be an issue. Am I missing something? I'm testing on node master branch.
The text was updated successfully, but these errors were encountered: