Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run linters before running tests? #16283

Closed
joyeecheung opened this issue Oct 18, 2017 · 1 comment
Closed

Run linters before running tests? #16283

joyeecheung opened this issue Oct 18, 2017 · 1 comment
Labels
build Issues and PRs related to build files or the CI. discuss Issues opened for discussions and feedbacks. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Comments

@joyeecheung
Copy link
Member

  • Version: master
  • Platform: all
  • Subsystem: build, test

When there are flaky errors make lint would not be run, so one has to manually trigger them, and it's easy to forget. I think this is pretty common because we have PRs failing linter CIs on the first run from time to time. Maybe we can run the linter before running the tests?
@joyeecheung joyeecheung added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels Oct 18, 2017
@joyeecheung joyeecheung mentioned this issue Oct 18, 2017
Closed
3 tasks
@joyeecheung joyeecheung added the discuss Issues opened for discussions and feedbacks. label Oct 18, 2017
@vsemozhetbyt vsemozhetbyt added the tools Issues and PRs related to the tools directory. label Oct 18, 2017
@gireeshpunathil
Copy link
Member

I guess its purpose is met, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. discuss Issues opened for discussions and feedbacks. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: run linter before running tests joyeecheung/node
3 participants
@joyeecheung @gireeshpunathil @vsemozhetbyt