You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Forking the project takes a huge amount of time, mainly because of the deps folder.
I was wondering if we can use submodules rather than having copies of the projects in the deps? then add a step in the make file or an instruction to download submodules aswell for those wishing to contribute.
I am not sure if node is changing code inside these deps to fit its needs, however this can be made for things that are copied as is.
The text was updated successfully, but these errors were encountered:
mscdex
added
question
Issues that look for answers.
meta
Issues and PRs related to the general management of the project.
labels
Nov 19, 2017
Just about any change requires that you run make test and for that you need a full checkout. Switching to submodules just adds an extra, unnecessary step.
What's more, submodules suck for greppability and they make changes that touch files in deps/ harder. It's like having a monorepo but without the actual benefits of a monorepo.
Forking the project takes a huge amount of time, mainly because of the
deps
folder.I was wondering if we can use
submodules
rather than having copies of the projects in thedeps
? then add a step in the make file or an instruction to download submodules aswell for those wishing to contribute.I am not sure if node is changing code inside these deps to fit its needs, however this can be made for things that are copied as is.
The text was updated successfully, but these errors were encountered: