Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Deps #17138

Closed
Bamieh opened this issue Nov 19, 2017 · 4 comments
Closed

Project Deps #17138

Bamieh opened this issue Nov 19, 2017 · 4 comments
Labels
meta Issues and PRs related to the general management of the project. question Issues that look for answers.

Comments

@Bamieh
Copy link
Contributor

Bamieh commented Nov 19, 2017

Forking the project takes a huge amount of time, mainly because of the deps folder.

I was wondering if we can use submodules rather than having copies of the projects in the deps? then add a step in the make file or an instruction to download submodules aswell for those wishing to contribute.

I am not sure if node is changing code inside these deps to fit its needs, however this can be made for things that are copied as is.

@mscdex mscdex added question Issues that look for answers. meta Issues and PRs related to the general management of the project. labels Nov 19, 2017
@Trott
Copy link
Member

Trott commented Nov 19, 2017

More than half of the deps folder is v8 and we float a lot of patches on that. See #16940.

Not saying "yes to submodules" or "no to submodules". Just providing some context/info.

@seishun
Copy link
Contributor

seishun commented Nov 20, 2017

I personally say "no to submodules". If the external project dies, you will no longer be able to (easily) check out and build an old commit.

@bnoordhuis
Copy link
Member

Just about any change requires that you run make test and for that you need a full checkout. Switching to submodules just adds an extra, unnecessary step.

What's more, submodules suck for greppability and they make changes that touch files in deps/ harder. It's like having a monorepo but without the actual benefits of a monorepo.

@seishun
Copy link
Contributor

seishun commented Nov 29, 2017

Closing as an answered question.

@seishun seishun closed this as completed Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. question Issues that look for answers.
Projects
None yet
Development

No branches or pull requests

5 participants