Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel/test-fs-utimes y2k38 test fails on mips(el) #17909

Closed
kapouer opened this issue Dec 29, 2017 · 6 comments
Closed

parallel/test-fs-utimes y2k38 test fails on mips(el) #17909

kapouer opened this issue Dec 29, 2017 · 6 comments
Labels
fs Issues and PRs related to the fs subsystem / file system. mips Issues and PRs related to the MIPS architecture. test Issues and PRs related to the tests.

Comments

@kapouer
Copy link
Contributor

kapouer commented Dec 29, 2017

When building nodejs 8.9.3 with shared libuv 1.18.0, on a debian build server:
https://db.debian.org/machines.cgi?host=mipsel-sil-01

not ok 545 parallel/test-fs-utimes
  ---
  duration_ms: 3.231
  severity: fail
  stack: |-
    assert.js:42
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: 2147483648 === 2147483647
        at Object.<anonymous> (/<<PKGBUILDDIR>>/test/parallel/test-fs-utimes.js:181:10)
        at Module._compile (module.js:635:30)
        at Object.Module._extensions..js (module.js:646:10)
        at Module.load (module.js:554:32)
        at tryModuleLoad (module.js:497:12)
        at Function.Module._load (module.js:489:3)
        at Function.Module.runMain (module.js:676:10)
        at startup (bootstrap_node.js:187:16)
        at bootstrap_node.js:608:3

This is the only unexpected test failure of the test-ci-js suite.
It seems 'mips' (and variants) should be added to

if (!process.arch.includes('arm') && !common.isSunOS) {

but since i don't understand why, i don't do the PR.

@bnoordhuis bnoordhuis added fs Issues and PRs related to the fs subsystem / file system. mips Issues and PRs related to the MIPS architecture. test Issues and PRs related to the tests. labels Dec 29, 2017
@bnoordhuis
Copy link
Member

That makes two of us. @refack Why was ARM excluded? It's not clear from reading through #13281.

@kapouer
Copy link
Contributor Author

kapouer commented Apr 26, 2018

Update: maybe because arm is the only supported 32-bit arch ?

@bnoordhuis
Copy link
Member

x86 was still being tested when you opened this issue so that can't be it. Ping @refack again.

@refack
Copy link
Contributor

refack commented Apr 26, 2018

That makes two of us. @refack Why was ARM excluded? It's not clear from reading through #13281.

AFAIK Y2K38 is predominantly a signed/unsigned issue not a 32bit issue.

@bnoordhuis AFAIR the intent of #13281 was to solve on Windows. We tested empirically and found that on our CI all POSIX can also handle this, except ARM and SmartOS, so they were excluded.
Since the fix was on node's side (not in libuv), I didn't dug any further, and assumed it's a kernel level fix.1

RE MIPS, we don't have a MIPS machine in CI.

@refack
Copy link
Contributor

refack commented Apr 26, 2018

P.S. this was also part of the #12607 / #12818 / #13256 cluster so I was probably afraid to break something again.

@jasnell
Copy link
Member

jasnell commented Jun 19, 2020

There's been no activity on this in 2 years. Closing. Can reopen if necessary.

@jasnell jasnell closed this as completed Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. mips Issues and PRs related to the MIPS architecture. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

4 participants