Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test-https-client-get-url #18495

Closed
BridgeAR opened this issue Feb 1, 2018 · 10 comments
Closed

Flaky test-https-client-get-url #18495

BridgeAR opened this issue Feb 1, 2018 · 10 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. openssl Issues and PRs related to the OpenSSL dependency. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Comments

@BridgeAR
Copy link
Member

BridgeAR commented Feb 1, 2018

https://ci.nodejs.org/job/node-test-commit-arm/13457/nodes=ubuntu1604-arm64/console

  duration_ms: 1.77
  severity: fail
  stack: |-
    events.js:116
          throw er; // Unhandled 'error' event
          ^
    
    Error: 281472695050240:error:1408F119:SSL routines:SSL3_GET_RECORD:decryption failed or bad record mac:../deps/openssl/openssl/ssl/s3_pkt.c:535:

Ping @nodejs/crypto

@BridgeAR BridgeAR added test Issues and PRs related to the tests. openssl Issues and PRs related to the OpenSSL dependency. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Feb 1, 2018
@BridgeAR
Copy link
Member Author

BridgeAR commented Feb 1, 2018

Seems like this has nothing to do with the test but something with openssl?

sequential/test-http2-timeout-large-write-file

https://ci.nodejs.org/job/node-test-commit-arm/13492/nodes=ubuntu1604-arm64/console

    events.js:116
          throw er; // Unhandled 'error' event
          ^
    Error: 281472942829568:error:1408F119:SSL routines:SSL3_GET_RECORD:decryption failed or bad record mac:../deps/openssl/openssl/ssl/s3_pkt.c:535:

@BridgeAR
Copy link
Member Author

Ping @nodejs/build PTAL

@maclover7
Copy link
Contributor

@BridgeAR Has this occurred again since last week? If not, may have been spurious

@BridgeAR
Copy link
Member Author

@maclover7 yes.

@BridgeAR
Copy link
Member Author

This is actually still one of the most common errors as far as I can tell.

Here another one:
https://ci.nodejs.org/job/node-test-commit-arm/13937/nodes=ubuntu1604-arm64/console

@BridgeAR
Copy link
Member Author

It seems consistent to always only be on Ubuntu 16.04 on ARM.

@BridgeAR
Copy link
Member Author

@rvagg @gibfahn @joyeecheung do you have any idea?

@joyeecheung
Copy link
Member

joyeecheung commented Feb 17, 2018

Not super familiar with this part of the code, but looks like it's similar to #4161 - somehow the buffer is not written properly and there are irrelevant data mixed there breaking the record

EDIT: also see #1595

@joyeecheung joyeecheung added the tls Issues and PRs related to the tls subsystem. label Feb 17, 2018
@rvagg
Copy link
Member

rvagg commented Mar 7, 2018

persistent random ubuntu1604-arm64 crypto failures are being handled in nodejs/build#842

@rvagg rvagg closed this as completed Mar 7, 2018
@neemah
Copy link

neemah commented Mar 12, 2018

screen shot 2018-03-12 at 15 27 31

Started to appear on Heroku (node 9.5.0) some days ago

Update: it's Ubuntu 14.04, as we run on Cedar-14 stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. openssl Issues and PRs related to the OpenSSL dependency. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

No branches or pull requests

5 participants