Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS Crypto Memory Leak ( New Relic ) #1866

Closed
miketheprogrammer opened this issue Jun 1, 2015 · 5 comments
Closed

TLS Crypto Memory Leak ( New Relic ) #1866

miketheprogrammer opened this issue Jun 1, 2015 · 5 comments
Labels
invalid Issues and PRs that are invalid. tls Issues and PRs related to the tls subsystem.

Comments

@miketheprogrammer
Copy link

Currently tracked on nodejs/node-v0.x-archive#9064
Being that io.js is an answer to the 'slowness' of NodeJS, I was hoping we could get a look at this issue in
iojs. There is an existing patch PR on the ticket.

Thank you for considering this. The memory leak is fairly large and serious for Micro Service oriented architectures especially.

@mscdex
Copy link
Contributor

mscdex commented Jun 1, 2015

@miketheprogrammer Have you tried with recent versions of io.js (v1.8.2+)? I know @indutny added some TLS memory leak fixes not too long ago...

@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Jun 1, 2015
@miketheprogrammer
Copy link
Author

I will definitely attempt using iojs latest on one of our production servers. However I was holding of on upgrading for a little while and staying on 0.12.

I feel from reading it that they are two seperate issues, however maybe this PR will at the very least alleviate some of the issues with the NewRelic memory leak. Imagine 800mb of extra memory over 6-10 hours depending on server activity. Absurd.

@ChALkeR
Copy link
Member

ChALkeR commented Jun 1, 2015

So, is this report against 0.12? What's the point of filing an issue at this moment, if you haven't tested iojs, then?

You could read this: #1522, it was also related with a lot of cert copies (btw that was not technically a leak), but there are no guarantees that you issue is the same. PR: #1529.

@rvagg
Copy link
Member

rvagg commented Jun 2, 2015

Not to be rude, but I'm going to close this issue @miketheprogrammer because the delta in tls between the current io.js and 0.12 is very large, almost everything has been touched, including the version of OpenSSL. So I'd suggest that this is an issue for 0.12 unless you've tested with io.js >= 2.0 and have some numbers to report, preferably with a piece of code that can be used to reproduce the issue.

Feel free to suggest this be re-opened if you think I've read this wrong.

@rvagg rvagg closed this as completed Jun 2, 2015
@miketheprogrammer
Copy link
Author

It's okay, I will test first. Apologies.

@ChALkeR ChALkeR added the invalid Issues and PRs that are invalid. label Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Issues and PRs that are invalid. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants