-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add search button to docs #19873
Comments
If you need just API docs, you can use the browser search on the page with docs consolidated in one page: |
that's another good workaround, although it would still be nice to be able to search from inside pages like https://nodejs.org/api/child_process.html |
cc @nodejs/website |
You may also post the request in https://github.com/nodejs/nodejs.org — that repository is closer to this issue. |
will do - thanks |
As suggested by @vsemozhetbyt, the appropriate repository for this issue is nodejs/nodejs.org Now that an issue has been submitted in there, this one should be closed. |
But docs are living in this repo, not on the website. |
@fhemberger I might be wrong, but I think they wanted to have a search bar on this page. Isn't the source code for that in the nodejs.org repo? |
@ryzokuken No, it's right here: Common misconception. ;) |
@ryzokuken The docs are maintained from within this repo. |
Oh, my bad. The more you know, I guess. |
Sorry, I just thought that such a bar would be added by some scripts at the site building stage. But if it should be added statically to HTML sources by the |
Most search bars require a server-side implementation though, unless we want to include a client-side index of keywords etc. This might become a bigger project, for the meantime, there are search engines and CTRL+F. |
@tniessen as long as the text under consideration is on the currently rendered page, Ctrl+F works perfectly, agreed. I believe they wanted to perform an API-wide search though, not limiting to the same page. Perhaps we could consider using something like Docusaurus instead? |
Many (if not most) API documentations don't have a search function, maybe an autocomplete feature ( |
Good idea but it too big so what about to extract a search feature from Docusaurus . I suggest @nodejs/website-redesign use Algolia to implement the feature. It is free for OSS 💯. |
It doesn't seem there's much progress here or anything really to be done. If anything happens it should be directed to the website-redesign repo. |
I'm very suprised there is not search functionality in the node docs. This would be a great addition to the docs and make it easier to navigate inside them.
workaround: google (not quite as convenient)
The text was updated successfully, but these errors were encountered: