You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fabiancook opened this issue
Apr 26, 2018
· 3 comments
Labels
errorsIssues and PRs related to JavaScript errors originated in Node.js core.promisesIssues and PRs related to ECMAScript promises.streamIssues and PRs related to the stream subsystem.
It appears that this[kError] could never be anything other than null, as in onError, iter.error = is used rather than iter[kError] = , this means in next, this[kError] will always be null, and the error will always be sitting there.
It looks like that if the error occurs while waiting for the next read it will invoke this[kLastReject], at any other point it will go unnoticed.
I can't see anywhere iter.error is used, which is why I am making this issue
If I'm misdirected in what I am seeing, please do correct me 😀
The text was updated successfully, but these errors were encountered:
vsemozhetbyt
added
stream
Issues and PRs related to the stream subsystem.
promises
Issues and PRs related to ECMAScript promises.
errors
Issues and PRs related to JavaScript errors originated in Node.js core.
labels
Apr 27, 2018
fabiancook
changed the title
ReadableAsyncIterator error`
ReadableAsyncIterator error not handled
Apr 27, 2018
errorsIssues and PRs related to JavaScript errors originated in Node.js core.promisesIssues and PRs related to ECMAScript promises.streamIssues and PRs related to the stream subsystem.
It appears that
this[kError]
could never be anything other thannull
, as inonError
,iter.error =
is used rather thaniter[kError] =
, this means innext
,this[kError]
will always be null, and the error will always be sitting there.It looks like that if the error occurs while waiting for the next read it will invoke
this[kLastReject]
, at any other point it will go unnoticed.I can't see anywhere
iter.error
is used, which is why I am making this issueIf I'm misdirected in what I am seeing, please do correct me 😀
Relevant link: https://github.com/nodejs/node/blob/master/lib/internal/streams/async_iterator.js#L61
The text was updated successfully, but these errors were encountered: