Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source <(npm completion) doesn't end in Node v10.4.0 #21213

Closed
teppeis opened this issue Jun 8, 2018 · 6 comments
Closed

source <(npm completion) doesn't end in Node v10.4.0 #21213

teppeis opened this issue Jun 8, 2018 · 6 comments
Labels
confirmed-bug Issues with confirmed bugs.

Comments

@teppeis
Copy link
Contributor

teppeis commented Jun 8, 2018

  • Version: v10.4.0
  • Platform: Darwin Kernel Version 17.5.0: Fri Apr 13 19:32:32 PDT 2018; root:xnu-4570.51.2~1/RELEASE_X86_64 x86_64
  • Subsystem:

In bash or zsh, following command doesn't end in Node v10.4.0.

$ cat <(node -v)
v10.4.0

Because of this change, source <(npm completion) in my .zshrc stops initializing a new shell.

In Node v10.3.0, the command ends normally.

@addaleax addaleax added the confirmed-bug Issues with confirmed bugs. label Jun 8, 2018
@addaleax
Copy link
Member

addaleax commented Jun 8, 2018

This was most likely caused by c2c9c0c /cc @bnoordhuis @tabkrz

Fwiw, for me this fails with:

./node[4191]: ../src/node.cc:3791:void node::PlatformExit(): Assertion `(err) != (-1)' failed.
v11.0.0-pre

The relevant strace line is

ioctl(0, SNDCTL_TMR_START or TCSETS, {B38400 opost isig icanon echo ...}) = -1 EIO (Input/output error)

@evanlucas
Copy link
Contributor

I just noticed this as well. Opened a revert PR at (#21257)

@ktaborski
Copy link
Contributor

Was someone able to reproduce this on another platform? I can not reproduce this on my RedHat7.

@addaleax
Copy link
Member

Yes, that crash above is on a Ubuntu 17.10 machine.

@evgenymarkov
Copy link

Same issue. I'm just calling process.exit() and node shows me stacktrace. This bug occurs in 10.4, but not in 10.3.

image

Platform: Darwin hellroot 17.6.0 Darwin Kernel Version 17.6.0: Tue May 8 15:22:16 PDT 2018; root:xnu-4570.61.1~1/RELEASE_X86_64 x86_64

@teppeis
Copy link
Contributor Author

teppeis commented Jun 13, 2018

Fixed in v10.4.1
Thank you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs.
Projects
None yet
Development

No branches or pull requests

5 participants