Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test-inspector-stop-profile-after-done on Windows #21233

Closed
Trott opened this issue Jun 9, 2018 · 3 comments
Closed

Investigate flaky test-inspector-stop-profile-after-done on Windows #21233

Trott opened this issue Jun 9, 2018 · 3 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol windows Issues and PRs related to the Windows platform.

Comments

@Trott
Copy link
Member

Trott commented Jun 9, 2018

  • Version: v11.0.0-pre (master)
  • Platform: win2016, vs2017
  • Subsystem: inspector

https://ci.nodejs.org/job/node-test-binary-windows/17913/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=2/console

not ok 565 sequential/test-inspector-stop-profile-after-done
  ---
  duration_ms: 0.643
  severity: fail
  exitcode: 1
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:61687/d9182774-879a-41b1-aaff-0365ee4e4d80
    [err] For help, see: https://nodejs.org/en/docs/inspector
    [err] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [out] {}
    [out] 
    [err] Debugger attached.
    [err] Waiting for the debugger to disconnect...
    [err] 
    { AssertionError [ERR_ASSERTION]: Input A expected to strictly equal input B:
    + expected - actual
    
    - 3221225477
    + 0
        at runTests (c:\workspace\node-test-binary-windows\test\sequential\test-inspector-stop-profile-after-done.js:28:10)
        at process._tickCallback (internal/process/next_tick.js:68:7)
      generatedMessage: true,
      name: 'AssertionError [ERR_ASSERTION]',
      code: 'ERR_ASSERTION',
      actual: 3221225477,
      expected: 0,
      operator: 'strictEqual' }
    1
  ...

@nodejs/v8-inspector @nodejs/platform-windows @nodejs/testing

@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform. inspector Issues and PRs related to the V8 inspector protocol labels Jun 9, 2018
@apapirovski
Copy link
Member

The vast majority of our failures are currently from the inspector, I would really like if we could avoid landing more changes to it until we get this situation under control.

@richardlau
Copy link
Member

  actual: 3221225477,

This is an access violation, e.g. the test crashed.

@bzoz
Copy link
Contributor

bzoz commented Jun 14, 2018

Is this the same as #19263?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

4 participants