Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with Node.js v10.5.0 #21591

Closed
ghost opened this issue Jun 29, 2018 · 11 comments
Closed

Crash with Node.js v10.5.0 #21591

ghost opened this issue Jun 29, 2018 · 11 comments
Labels
windows Issues and PRs related to the Windows platform.

Comments

@ghost
Copy link

ghost commented Jun 29, 2018

  • Version: v10.5.0
  • Platform: Windows 10 x64
  • Subsystem: /

Here is the bug I noticed today. This code

(_=>_(_))(_=>eval(`(${_})(${_})`))

in Chrome throws RangeError: Maximum call stack size exceeded, in Firefox throws InternalError: too much recursion, but in Node.js crashes the process with no warnings or errors. Tried reducing max old space size and also tried reducing stack size, but the bug persists.

sorry for bad english

@mscdex
Copy link
Contributor

mscdex commented Jun 29, 2018

FWIW it doesn't crash for me on Linux with no special node parameters.

@jasnell
Copy link
Member

jasnell commented Jun 29, 2018

Running this within the repl, I get a proper (if not extremely verbose) error.

@ghost
Copy link
Author

ghost commented Jun 29, 2018

not sure if it helps, but here is my output:

C:\>node
> (_=>_(_))(_=>eval(`(${_})(${_})`))

C:\>echo %ERRORLEVEL%
-1073741571

C:\>

and same if run like node server.js same happen

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Jun 29, 2018

For me, on Windows 7 x64, this crashes REPL with no errors on 06.14.3, 08.11.3, 10.5.0, last nightly and canary.

@ChALkeR ChALkeR added the windows Issues and PRs related to the Windows platform. label Jul 1, 2018
@bzoz
Copy link
Contributor

bzoz commented Jul 5, 2018

-1073741571 is 0xC00000FD which is stack overflow

@ghost
Copy link
Author

ghost commented Jul 5, 2018

-1073741571 is 0xC00000FD which is stack overflow

I think it would be better if Node.js throws an error in case of stack owerflow (like browsers do) instead of terminating the process.

@gireeshpunathil
Copy link
Member

this is fixed via #26832 . Closing, pls re-open if I am wrong

@Hakerh400
Copy link
Contributor

Issue #26829 is unrelated (as explained in #26829 (comment)) and thus #26832 is also unrelated. I can confirm that this issue still reproduces (on master) on some platforms, including windows 8.1

The real issue is v8:8053. I reported it more than a year ago, they confirmed the issue, but still no updates. Note that the issue also reproduces in Chrome.

@gireeshpunathil
Copy link
Member

thanks @Hakerh400 for the explanation. seeing the linked issue, and seeing that this is not happening in mac where I tested, I thought this is fixed. re-opening.

@Hakerh400
Copy link
Contributor

Does not reproduce on master and in v14.0.0. If nobody can reproduce on master I think this can be closed.

@juanarbol
Copy link
Member

Does not reproduce on master and in v14.0.0. If nobody can reproduce on master I think this can be closed.

Thank you @Hakerh400, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

8 participants