Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple tests will fail on Windows. #22147

Closed
briete opened this issue Aug 6, 2018 · 5 comments
Closed

Multiple tests will fail on Windows. #22147

briete opened this issue Aug 6, 2018 · 5 comments
Labels
test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@briete
Copy link
Contributor

briete commented Aug 6, 2018

  • Version: 11.0.0-pre (master)
  • Platform: windows7 64bit
  • Subsystem:

It will cause errors in multiple Windows tests.
I am using Git for Windows Bash tool.
Paste the error log.

running 'python tools\test.py --mode=release  -J default doctool addons addons-napi'
Skipping pseudo-tty tests, as pseudo terminals are not available on Windows.
=== release test-http-1.0 ===
Path: parallel/test-http-1.0
assert.js:84
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected inputs to be strictly equal:
+ actual - expected

+ 'HTTP/1.1 200 OK\r\nContent-Type: text/plain\r\nConnection: close\r\nTransfer-Encoding: chunked\r\n\r\n7\r\nHello, \r\n6\r\nworld!\r\n0\r\n\r\n'
- 'HTTP/1.1 200 OK\r\nContent-Type: text/plain\r\nConnection: close\r\nTransfer-Encoding: chunked\r\n\r\nd\r\nHello, world!\r\n0\r\n\r\n'
    at response_validator (C:\Users\sato14\github\node\test\parallel\test-http-1.0.js:158:12)
    at Socket.<anonymous> (C:\Users\sato14\github\node\test\parallel\test-http-1.0.js:54:7)
    at Socket.<anonymous> (C:\Users\sato14\github\node\test\common\index.js:467:15)
    at Socket.emit (events.js:187:15)
    at endReadableNT (_stream_readable.js:1081:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
Command: C:\Users\sato14\github\node\Release\node.exe C:\Users\sato14\github\node\test\parallel\test-http-1.0.js
=== release test-http-client-timeout-with-data ===
Path: parallel/test-http-client-timeout-with-data
assert.js:84
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected inputs to be strictly equal:

0 !== 1

    at ClientRequest.<anonymous> (C:\Users\sato14\github\node\test\parallel\test-http-client-timeout-with-data.js:49:14)
    at ClientRequest.<anonymous> (C:\Users\sato14\github\node\test\common\index.js:467:15)
    at Object.onceWrapper (events.js:273:13)
    at ClientRequest.emit (events.js:182:13)
    at Socket.emitRequestTimeout (_http_client.js:669:40)
    at Object.onceWrapper (events.js:273:13)
    at Socket.emit (events.js:182:13)
    at Socket._onTimeout (net.js:448:8)
    at ontimeout (timers.js:454:11)
    at tryOnTimeout (timers.js:326:5)
Command: C:\Users\sato14\github\node\Release\node.exe C:\Users\sato14\github\node\test\parallel\test-http-client-timeout-with-data.js
=== release test-http-multi-line-headers ===
Path: parallel/test-http-multi-line-headers
assert.js:84
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected inputs to be strictly equal:
+ actual - expected

+ 'text/plain;'
- 'text/plain; x-unix-mode=0600; name="hello.txt"'
              ^
    at ClientRequest.<anonymous> (C:\Users\sato14\github\node\test\parallel\test-http-multi-line-headers.js:51:12)
    at ClientRequest.<anonymous> (C:\Users\sato14\github\node\test\common\index.js:467:15)
    at Object.onceWrapper (events.js:273:13)
    at ClientRequest.emit (events.js:182:13)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:563:21)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:109:17)
    at Socket.socketOnData (_http_client.js:449:20)
    at Socket.emit (events.js:182:13)
    at addChunk (_stream_readable.js:283:12)
    at readableAddChunk (_stream_readable.js:264:11)
Command: C:\Users\sato14\github\node\Release\node.exe C:\Users\sato14\github\node\test\parallel\test-http-multi-line-headers.js
=== release test-http-readable-data-event ===
Path: parallel/test-http-readable-data-event
assert.js:84
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected inputs to be strictly equal:
+ actual - expected

+ null
- 'Hello again later!'
    at IncomingMessage.res.on.common.mustCall (C:\Users\sato14\github\node\test\parallel\test-http-readable-data-event.js:42:16)
    at IncomingMessage.<anonymous> (C:\Users\sato14\github\node\test\common\index.js:467:15)
    at IncomingMessage.emit (events.js:182:13)
    at emitReadable_ (_stream_readable.js:531:12)
    at onEofChunk (_stream_readable.js:509:7)
    at readableAddChunk (_stream_readable.js:232:5)
    at IncomingMessage.Readable.push (_stream_readable.js:219:10)
    at Socket.socketCloseListener (_http_client.js:361:11)
    at Socket.emit (events.js:187:15)
    at TCP._handle.close (net.js:599:12)
Command: C:\Users\sato14\github\node\Release\node.exe C:\Users\sato14\github\node\test\parallel\test-http-readable-data-event.js
--- TIMEOUT ---
=== release test-benchmark-tls ===
Path: sequential/test-benchmark-tls
(node:10572) [DEP0064] DeprecationWarning: tls.createSecurePair() is deprecated. Please use tls.TLSSocket instead.
events.js:167
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onread (net.js:660:25)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:82:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
    at process._tickCallback (internal/process/next_tick.js:63:19)
assert.js:84
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected inputs to be strictly equal:

1 !== 0

    at ChildProcess.child.on (C:\Users\sato14\github\node\test\common\benchmark.js:35:12)
    at ChildProcess.emit (events.js:182:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:239:12)
Command: C:\Users\sato14\github\node\Release\node.exe C:\Users\sato14\github\node\test\sequential\test-benchmark-tls.js
=== release test-http-server-keep-alive-timeout-slow-client-headers ===
Path: sequential/test-http-server-keep-alive-timeout-slow-client-headers
assert.js:338
    throw err;
    ^

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert.ok(response.includes('HTTP/1.1 200 OK\r\n'))

    at onHeaders (C:\Users\sato14\github\node\test\sequential\test-http-server-keep-alive-timeout-slow-client-headers.js:52:14)
    at Socket.onData (C:\Users\sato14\github\node\test\sequential\test-http-server-keep-alive-timeout-slow-client-headers.js:47:9)
    at Socket.emit (events.js:182:13)
    at addChunk (_stream_readable.js:283:12)
    at readableAddChunk (_stream_readable.js:260:13)
    at Socket.Readable.push (_stream_readable.js:219:10)
    at TCP.onread (net.js:639:20)
Command: C:\Users\sato14\github\node\Release\node.exe C:\Users\sato14\github\node\test\sequential\test-http-server-keep-alive-timeout-slow-client-headers.js
[07:15|% 100|+ 2341|-   6]: Done

@Trott
Copy link
Member

Trott commented Aug 6, 2018

@nodejs/platform-windows

@Trott Trott added windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Aug 6, 2018
@joyeecheung
Copy link
Member

joyeecheung commented Aug 7, 2018

Looks like the failures are caused by incorrect line break settings. I've never seen those when I work on Windows though, can you try using cmd instead of Git bash? Also did you use the makefile? (I don't think that worked on Windows the last time I've tried it. It's always vcbuild.bat for Windows)

@briete
Copy link
Contributor Author

briete commented Aug 8, 2018

@joyeecheung I tried using cmd, but a similar AssertionError happened. I do not use the makefile. I ran it with vcbuild test.

@bzoz
Copy link
Contributor

bzoz commented Aug 9, 2018

@briete could you provide exact windows version and complete log from vcbuild test?

@briete
Copy link
Contributor Author

briete commented Aug 13, 2018

@bzoz

Windows version
Windows7 Professional
Version 6.1 build 7601: Service Pack 1

complete log
20180813.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

4 participants