Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky parallel/test-stdio-pipe-redirect #22378

Closed
joyeecheung opened this issue Aug 17, 2018 · 5 comments
Closed

Investigate flaky parallel/test-stdio-pipe-redirect #22378

joyeecheung opened this issue Aug 17, 2018 · 5 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Aug 17, 2018

Refs: nodejs/reliability#14

Reason parallel/test-stdio-pipe-redirect
Type JS_TEST_FAILURE
Failed PR 3 (#22320, #22202, #21593)
Appeared test-azure_msft-win10-x64-1, test-rackspace-win2008r2-x64-1, test-azure_msft-win2012r2-x64-2, test-rackspace-win2012r2-x64-2, test-azure_msft-win2016-x64-2, test-azure_msft-win10-x64-4, test-rackspace-win2012r2-x64-1, test-azure_msft-win2016-x64-4, test-azure_msft-win10-x64-3, test-rackspace-win2012r2-x64-9, test-azure_msft-win2012r2-x64-1
First CI https://ci.nodejs.org/job/node-test-pull-request/16458/
Last CI https://ci.nodejs.org/job/node-test-pull-request/16489/
Example
not ok 360 parallel/test-stdio-pipe-redirect
  ---
  duration_ms: 0.599
  severity: crashed
  stack: |-
    oh no!
    exit code: CRASHED
  ...

@joyeecheung joyeecheung added flaky-test Issues and PRs related to the tests with unstable failures on the CI. v8.x labels Aug 17, 2018
@joyeecheung
Copy link
Member Author

joyeecheung commented Aug 17, 2018

This looks like v8.x only, and windows-only

@joyeecheung joyeecheung added the windows Issues and PRs related to the Windows platform. label Aug 17, 2018
@joyeecheung
Copy link
Member Author

A more detailed stack

URL        https://ci.nodejs.org/job/node-test-binary-windows/COMPILED_BY=vs2015-x86,RUNNER=win2012r2,RUN_SUBSET=1/19259/console
Type       JS_TEST_FAILURE
Built On   test-rackspace-win2012r2-x64-2
Reason
  not ok 360 parallel/test-stdio-pipe-redirect
    ---
    duration_ms: 0.703
    severity: fail
    stack: |-
      Assertion failed: 0, file c:\workspace\node-compile-windows\deps\uv\src\win\req-inl.h, line 214
    ...

@MylesBorins
Copy link
Contributor

@joyeecheung I think I landed a fix for this one. It shouldn't be showing up anymore

@joyeecheung
Copy link
Member Author

@MylesBorins Thanks, do you know which commit fixed that?

@MylesBorins
Copy link
Contributor

I believe it is related to 2ec981b

It should have been landed before the test landed on 8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

2 participants