Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8-canary builds do not include linux-amd64 arch recently #22757

Closed
aalexand opened this issue Sep 7, 2018 · 5 comments
Closed

v8-canary builds do not include linux-amd64 arch recently #22757

aalexand opened this issue Sep 7, 2018 · 5 comments

Comments

@aalexand
Copy link

aalexand commented Sep 7, 2018

Looking at recent v8-canary builds like https://nodejs.org/download/v8-canary/v11.0.0-v8-canary20180906f69ce875ca/, I don't see linux-amd64 arch present, is that intended?

@ofrobots @nolanmar511 FYI

@richardlau
Copy link
Member

@aalexand it's currently broken, see nodejs/node-v8#77

@aalexand
Copy link
Author

@richardlau nodejs/node-v8#77 is marked as fixed now, but there are still no canary builds with linux-amd64 bits included. Actually, now the latest canary build at https://nodejs.org/download/v8-canary/ seems to be from 10-Sep-2018 which is more than 2 weeks ago, is that expected?

@richardlau
Copy link
Member

@targos @refack Is the lack of v8-canary builds related to #22920?

@refack
Copy link
Contributor

refack commented Sep 28, 2018

AFAIU soon after we merged V8 7.0 to master, we bumped our canary-base to 7.1.
This time it does not build without updates to the gyp scaffolding. So yes until we land #22920 we can't build with 7.1 (but we're very very close, I'm estimating day or two).

As for the original missing linux-amd64 build, nodejs/node-v8#77 was fixed just before we switched to 7.1, so we might have not ported that fix to the canary branch.

tl;dr we are not missing anything, since nothing new was done on the canary branch, and the nightly master builds are based on V8 7.0 which is even not "stable" yet, so they are king of bleeding-edge anyway.

@refack
Copy link
Contributor

refack commented Oct 6, 2018

#22920 landed, so they are back https://nodejs.org/download/v8-canary/v11.0.0-v8-canary201810059c29459c41/ everything but smartOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants