You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
vsemozhetbyt opened this issue
Oct 16, 2018
· 5 comments
Labels
discussIssues opened for discussions and feedbacks.docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.
This can simplify nits addressing. We may need to update our contributing guides (including how-to steps to sync local branches with remote changes if needed).
The text was updated successfully, but these errors were encountered:
vsemozhetbyt
added
meta
Issues and PRs related to the general management of the project.
doc
Issues and PRs related to the documentations.
discuss
Issues opened for discussions and feedbacks.
labels
Oct 16, 2018
IMHO it's a very nice feature for reviewers who are willing to make the extra effort.
We do need to be a little bit careful since GitHub is not an IDE, so when suggesting code changes it should be stated explicitly if it was tested, or is pseudocode.
We may need to update our contributing guides (including how-to steps to sync local branches with remote changes if needed).
I believe there's a balance to strike here. IMHO our contribution guide should focus on the things that are specific to work in this repo. While points that require general git and GitHub literacy should be referred to better guides. Such as the new https://lab.github.com/
A doubt: technically, any Collaborator can assign themselves to a PR and accept an own proposed change. This can alleviate nit addressing for the PR author, but also can be felt like a bit arbitrarily thing.
discussIssues opened for discussions and feedbacks.docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.
New GitHub feature:
https://help.github.com/articles/incorporating-feedback-in-your-pull-request/#applying-a-suggested-change
This can simplify nits addressing. We may need to update our contributing guides (including how-to steps to sync local branches with remote changes if needed).
The text was updated successfully, but these errors were encountered: