Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib: check callback is function #2397

Closed
jasnell opened this issue Aug 16, 2015 · 2 comments
Closed

zlib: check callback is function #2397

jasnell opened this issue Aug 16, 2015 · 2 comments
Labels
good first issue Issues that are suitable for first-time contributors. zlib Issues and PRs related to the zlib subsystem.

Comments

@jasnell
Copy link
Member

jasnell commented Aug 16, 2015

joyent/node PR nodejs/node-v0.x-archive#6525 was an attempt to add
checking to zlib to ensure that the callback was a function. That PR cannot land
for a variety of reasons. I note, however, that zlib, and other parts of the code still
do not check callbacks consistently. I know this has been discussed a number of
times, but since I'm closing the original PR, I wanted to make sure the issue wasn't
lost.

@brendanashworth brendanashworth added the zlib Issues and PRs related to the zlib subsystem. label Aug 16, 2015
@Fishrock123 Fishrock123 added the good first issue Issues that are suitable for first-time contributors. label Aug 25, 2015
@Fishrock123
Copy link
Contributor

#2596 (comment)

Closing, the error here denotes a bug in user code. There is no way to get the resulting data otherwise, and it is a no-op.

@kulkarniankita
Copy link

Is this still a issue and needs to be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are suitable for first-time contributors. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants