Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intl: replace icutrim.py with ICU data slicer #25136

Closed
srl295 opened this issue Dec 19, 2018 · 10 comments
Closed

Intl: replace icutrim.py with ICU data slicer #25136

srl295 opened this issue Dec 19, 2018 · 10 comments
Assignees
Labels
i18n-api Issues and PRs related to the i18n implementation. stalled Issues and PRs that are stalled. wip Issues and PRs that are still a work in progress.

Comments

@srl295
Copy link
Member

srl295 commented Dec 19, 2018

In Node 0.12, I added icutrim.py and the config file icu_small.json to enable Node's "english only" default ICU packaging (aka icu-small).

ICU now has its own data slicer, see https://unicode-org.atlassian.net/browse/ICU-10923 (see the design doc at the top of that issue)

  • Change Node to use this slicer where available with the goal of phasing out special code.
  • Also, make sure that ICU's syntax is flexible enough to support node.

I'd encourage node people ( cc @nodejs/intl ) to visit the ICU issue and comment on the syntax.

Describe the solution you'd like
Less headache for Node maintainers! Less special purpose code!

Describe alternatives you've considered
do nothing - keep maintaining these python scripts

@srl295 srl295 self-assigned this Dec 19, 2018
@srl295 srl295 added wip Issues and PRs that are still a work in progress. i18n-api Issues and PRs related to the i18n implementation. labels Dec 19, 2018
@mhdawson
Copy link
Member

Sounds good to me.

@bnoordhuis
Copy link
Member

And me. I second Jungshik's comment about the python script being the best option for us/them.

@targos
Copy link
Member

targos commented Jul 21, 2019

@srl295 What's the status?

@srl295
Copy link
Member Author

srl295 commented Nov 22, 2019

@targos nothing yet

@jasnell
Copy link
Member

jasnell commented Jun 19, 2020

Ping @srl295 ... does this need to remain open?

@srl295
Copy link
Member Author

srl295 commented Sep 24, 2021

@jasnell searched for this ticket because --with-intl=small-icu seems to be broken, could be a good time to bring the slicer in

@srl295 srl295 added the stalled Issues and PRs that are stalled. label Sep 24, 2021
@github-actions
Copy link
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@srl295
Copy link
Member Author

srl295 commented Sep 24, 2021

i'll at least mark it stalled. fyi @nodejs/i18n-api

@srl295
Copy link
Member Author

srl295 commented Sep 24, 2021

So I'm setting myself a deadline here

@RedYetiDev
Copy link
Member

(The stalled bot doesn't appear to be working, so I've manually closed)

@RedYetiDev RedYetiDev closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation. stalled Issues and PRs that are stalled. wip Issues and PRs that are still a work in progress.
Projects
None yet
Development

No branches or pull requests

6 participants